Skip to content

Docs: redesign home page, and add new theme#1558

Merged
tzach merged 17 commits intoscylladb:masterfrom
lauranovich:upgrade-theme
Oct 5, 2021
Merged

Docs: redesign home page, and add new theme#1558
tzach merged 17 commits intoscylladb:masterfrom
lauranovich:upgrade-theme

Conversation

@lauranovich
Copy link
Copy Markdown
Contributor

This PR

  1. Upgrades the Sphinx theme to 1.o
  2. Fixes issues in compiling
  3. changes the Home Page to the more modern design
  4. Includes the new Scylla-Monitoring Stack mascot

@lauranovich
Copy link
Copy Markdown
Contributor Author

@dgarcia360 the tiling is not working - please take a look and comment

@lauranovich lauranovich marked this pull request as draft October 3, 2021 14:34
Comment thread docs/source/index.rst
Comment thread docs/Makefile Outdated
Comment thread docs/source/index.rst
Comment thread docs/source/index.rst Outdated
@lauranovich lauranovich marked this pull request as ready for review October 4, 2021 08:56
@lauranovich
Copy link
Copy Markdown
Contributor Author

@dgarcia360 - I think this is now ready

Comment thread docs/source/index.rst Outdated
@tzach
Copy link
Copy Markdown
Contributor

tzach commented Oct 4, 2021

Remove inner page ToC, for example /install/monitoring_stack/
image

the left menu replace it now

@lauranovich
Copy link
Copy Markdown
Contributor Author

@dgarcia360 please look at the comments inside this PR
some items you asked me to do didn't work as described or were not included in the documentation
we need to change that, please!

@tzach
Copy link
Copy Markdown
Contributor

tzach commented Oct 4, 2021

Link to extrabl resource need the external link icons, including in the left menu.
See GitHub Project, Scylla University Lesson below
image

@lauranovich
Copy link
Copy Markdown
Contributor Author

@tzach I think we're good to go the External Link not being flagged @dgarcia360 - this is a regression. We need this fixed.

@tzach
Copy link
Copy Markdown
Contributor

tzach commented Oct 4, 2021

I see

404 GET /_static/expertrec.js

errors from the site

@lauranovich
Copy link
Copy Markdown
Contributor Author

@tzach - the sidebar issue is being handled by the theme issue @dgarcia360 mentioned. ( scylladb/sphinx-scylladb-theme#227) so I think we can merge. @dgarcia360 any other changes?

@tzach
Copy link
Copy Markdown
Contributor

tzach commented Oct 5, 2021

Waiting for a solution (or understanding) of the new 404 issue above

@tzach
Copy link
Copy Markdown
Contributor

tzach commented Oct 5, 2021

404 GET /_static/expertrec.js

Issue source is the following HTML code

<script src="_static/expertrec.js"></script>

Look like the new theme dropped the expertrec.js which do exist in older version

@tzach
Copy link
Copy Markdown
Contributor

tzach commented Oct 5, 2021

@lauranovich
Copy link
Copy Markdown
Contributor Author

Linkcheck passes on the PR, fixed some old broken links

Comment thread docs/source/install/monitoring_stack.rst Outdated
Comment thread docs/source/install/monitoring_stack.rst Outdated
@dgarcia360
Copy link
Copy Markdown
Contributor

dgarcia360 commented Oct 5, 2021

@dgarcia360
Copy link
Copy Markdown
Contributor

some items you asked me to do didn't work as described or were not included in the documentation
we need to change that, please!

@lauranovich I'm updating the docs with in-detail reference documentation for options of the components "topic-box", "hero-box", and "panel-box".

External Link not being flagged @dgarcia360 - this is a regression

Thanks, I didn't spot this bug yet. I'll fix it with scylladb/sphinx-scylladb-theme#227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants