Skip to content

docs: update theme 1.3#3217

Merged
karol-kokoszka merged 1 commit intoscylladb:masterfrom
dgarcia360:docs-update-theme-1.3
Nov 3, 2022
Merged

docs: update theme 1.3#3217
karol-kokoszka merged 1 commit intoscylladb:masterfrom
dgarcia360:docs-update-theme-1.3

Conversation

@dgarcia360
Copy link
Copy Markdown
Contributor

@dgarcia360 dgarcia360 commented Aug 19, 2022

Related issue scylladb/sphinx-scylladb-theme#548

ScyllaDB Sphinx Theme 1.3 is now released 🥳

We’ve added better redirects support and introduced numerous UI updates.

You can read more about all notable changes here.

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.3.x:

image

@dgarcia360
Copy link
Copy Markdown
Contributor Author

@annastuchlik @tzach please review

@karol-kokoszka
Copy link
Copy Markdown
Collaborator

@annastuchlik @tzach Can you review ? Is this PR still valid ? Do you want me to merge it ?

@annastuchlik
Copy link
Copy Markdown
Collaborator

@karol-kokoszka Thanks for bringing this up. This PR is definitely valid as it updates the Sphinx theme. I've just reviewed it, and it looks great.
It's ready to be merged.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karol-kokoszka karol-kokoszka merged commit 7f05600 into scylladb:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants