Skip to content

fix(hydra): switch docker base to 3.10.12-slim-bullseye#6348

Merged
fruch merged 1 commit intoscylladb:masterfrom
fruch:move_to_python_3.10.12
Jul 11, 2023
Merged

fix(hydra): switch docker base to 3.10.12-slim-bullseye#6348
fruch merged 1 commit intoscylladb:masterfrom
fruch:move_to_python_3.10.12

Conversation

@fruch
Copy link
Copy Markdown
Contributor

@fruch fruch commented Jul 11, 2023 •
edited
Loading

looks like we are using a very early release of python 3.10 and we didn't got the revert that was done in python/cpython#98503 rebuilding image with latest release of python 3.10

Fixes: #6345
Ref: python/cpython#98503

Testing:

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

@fruch
fix(hydra): switch docker base to 3.10.12-slim-bullseye
90cab65 
looks like we are using a very early release of python 3.10
and we didn't got the revert that was done in python/cpython#98503
rebuilding image with latest release of python 3.10

Fixes: scylladb#6345
Ref: python/cpython#98503
vponomaryov
vponomaryov reviewed Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it tested?

@fruch
Copy link
Copy Markdown
Contributor Author

fruch commented Jul 11, 2023

Was it tested?

just here on the PR.

as for the specific issue it should solve, we'll need to run a bunch of artifacts tests at the same time. (but we don't have a specific reproducer)

vponomaryov
vponomaryov approved these changes Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch added the New Hydra Version PR# introduces new Hydra version label Jul 11, 2023
@fruch fruch requested a review from aleksbykov July 11, 2023 10:41
@fruch fruch mentioned this pull request Jul 11, 2023
Merged
7 tasks
soyacz
soyacz approved these changes Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Copy Markdown
Contributor Author

fruch commented Jul 11, 2023

All artifacts tests passed

@fruch fruch merged commit 61bd889 into scylladb:master Jul 11, 2023
@fruch fruch deleted the move_to_python_3.10.12 branch October 17, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vponomaryov vponomaryov vponomaryov approved these changes

@soyacz soyacz soyacz approved these changes

@enaydanov enaydanov Awaiting requested review from enaydanov

@aleksbykov aleksbykov Awaiting requested review from aleksbykov

Assignees

@fruch fruch

Labels

New Hydra Version PR# introduces new Hydra version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SCT fails with OSError: [Errno 98] Address already in use

3 participants

@fruch @vponomaryov @soyacz