Skip to content

docs: Update theme 1.4.1#212

Merged
fruch merged 5 commits intoscylladb:masterfrom
dgarcia360:docs-update-theme-1-4
Apr 3, 2023
Merged

docs: Update theme 1.4.1#212
fruch merged 5 commits intoscylladb:masterfrom
dgarcia360:docs-update-theme-1-4

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

Related issue scylladb/sphinx-scylladb-theme#707

ScyllaDB Sphinx Theme 1.4 is now released 🥳

You can read more about all notable changes here.

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.4.x:

image

@dgarcia360 dgarcia360 requested a review from annastuchlik March 14, 2023 09:57
@dgarcia360
Copy link
Copy Markdown
Collaborator Author

@annastuchlik Could you please review?

@fruch
Copy link
Copy Markdown

fruch commented Mar 27, 2023

@annastuchlik can you take a look ?

@annastuchlik
Copy link
Copy Markdown

@fruch I'm getting some errors when building this PR. I'm looking into it with @dgarcia360.

@dgarcia360 dgarcia360 force-pushed the docs-update-theme-1-4 branch from 1fad482 to 0e30022 Compare March 31, 2023 08:53
Copy link
Copy Markdown

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik
Copy link
Copy Markdown

@fruch This PR can be merged.

@fruch fruch merged commit 4f5fd81 into scylladb:master Apr 3, 2023
@dgarcia360 dgarcia360 deleted the docs-update-theme-1-4 branch April 4, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants