fix: fallback to any known node when control node not found by endpoint#847
Merged
dkropachev merged 1 commit intoscylladb:scylla-4.xfrom Mar 19, 2026
Conversation
When the control connection endpoint doesn't match any node in metadata (e.g. with PrivateLink or proxy setups), fall back to the first available node instead of immediately throwing an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findNode(channel.getEndPoint())returns empty (e.g. PrivateLink/proxy setups where the control endpoint differs from metadata), fall back to the first available node in metadata instead of throwing anIllegalStateException..orElse()with aMap.Entry(type mismatch) followed by.orElseThrow()on a non-Optional, which didn't compile.Test plan
IllegalStateExceptionis still thrown when metadata has zero nodes