3.x: consider nodes from remote rack as remote#588
Merged
dkropachev merged 2 commits intoscylladb:scylla-3.xfrom Aug 20, 2025
Merged
Conversation
Considering them as `LOCAL` confuses `TokenAwarePolicy` as result in some cases it shuffle nodes from non-local and local racks together.
planing There are no test for it, as result policy does not work as expected. Let's have some tests for it.
dkropachev
force-pushed
the
dk/3.x-consider-nodes-from-remote-rack-as-remote
branch
from
c5a1b72 to
267a0af
Compare
Bouncheck
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering them as
LOCALconfusesTokenAwarePolicyas result in some cases it shuffle nodes from non-local and local racks together.Add some unit tests for distance calculation and query planing.
Fixes: #255