Skip to content

docs: update theme 1.5#212

Merged
avelanarius merged 5 commits intoscylladb:scylla-3.xfrom
dgarcia360:docs-update-theme-1.4
Dec 7, 2023
Merged

docs: update theme 1.5#212
avelanarius merged 5 commits intoscylladb:scylla-3.xfrom
dgarcia360:docs-update-theme-1.4

Conversation

@dgarcia360
Copy link
Copy Markdown

Related issue scylladb/sphinx-scylladb-theme#707

ScyllaDB Sphinx Theme 1.4 is now released 🥳

You can read more about all notable changes here.

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.4.x:

image

@dgarcia360 dgarcia360 force-pushed the docs-update-theme-1.4 branch 2 times, most recently from 6a0054c to 06c099e Compare March 31, 2023 14:57
docs: update conf.py

docs: update conf.py

docs: Update conf.py

docs: update conf.py

docs: Update conf.py

docs: update conf.py
@dgarcia360 dgarcia360 force-pushed the docs-update-theme-1.4 branch from 06c099e to 224d8a3 Compare March 31, 2023 15:03
@dgarcia360 dgarcia360 marked this pull request as draft March 31, 2023 15:24
docs: test

docs: add skip warnings option
@dgarcia360 dgarcia360 force-pushed the docs-update-theme-1.4 branch from 6469282 to 71a5d54 Compare April 4, 2023 08:55
@dgarcia360 dgarcia360 marked this pull request as ready for review April 4, 2023 09:00
@dgarcia360 dgarcia360 changed the title docs: update theme 1.4.1 docs: update theme 1.4 Apr 4, 2023
@dgarcia360
Copy link
Copy Markdown
Author

cc/ @annastuchlik

@annastuchlik
Copy link
Copy Markdown

@avelanarius Can you merge this PR to update the Sphinx theme? The PR looks good and the failing checks seem to be test-related. Could you look into it?

@dgarcia360 dgarcia360 changed the title docs: update theme 1.4 docs: update theme 1.5 Jun 2, 2023
@dgarcia360
Copy link
Copy Markdown
Author

dgarcia360 commented Jun 2, 2023

@annastuchlik @avelanarius Updated the pull request to update to 1.5. You can read more about all changes here.

Copy link
Copy Markdown

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik
Copy link
Copy Markdown

@avelanarius Please merge.

@annastuchlik
Copy link
Copy Markdown

@avelanarius Please merge this PR. We'd like to update the theme to 1.6, so this PR should be merged before that.

@annastuchlik
Copy link
Copy Markdown

@avelanarius ping

@avelanarius avelanarius merged commit 51ff0d5 into scylladb:scylla-3.x Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants