Repository navigation
fix bug with get_values and labels - #367
Merged
Merged
Conversation
This was referenced Oct 8, 2023
Member
Author
|
I have modified the way we deal with the background. Now values that are present in an element and not in the table (so a labels element with a background value 0 is one of the cases), do not trigger an error when This more general approach is implemented here: #376 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is minor and unlocks other PRs, I'll merge it straight away.
1. Fix bug with
get_values()for labelsget_values()was failing when the internal function_filter_table_by_elements()was called withmatch_rows=True, because the aggregated table from blobs doesn't contain the background in the table (for how we implemented the aggregate function), while the labels has it.To fix, I simply discard the background index when matching a labels element to the table.
2. Minor: fix an assert
Fix an assert that was wrongly written and refactored into the function
_get_element()