Skip to content

add_table() method would be consistent w. other add_[attribute]() #451

Closed

Description

@MichielVerCruysse

Adding a table as follows
sdata.table = myTable
is inconsistent with the method for adding images, labels, points and shapes. I feel like an add_table method would be clearer.

Activity

  1. changed the title [-]add_table method would be consistent w. other add_[attribute][/-] [+]add_table() method would be consistent w. other add_[attribute]()[/+] on Feb 6, 2024
  2. LucaMarconato commented on Feb 6, 2024

    @LucaMarconato
    Member

    Thanks @MichielVerCruysse for reporting this. We actually fixed this inconsistency but we haven't made a release yet. It will probably take a few more weeks until we cut one.

    We took another approach: in #329 we remove the add_image(), add_labels(), ... methods and in the branch https://github.com/scverse/spatialdata/tree/multi_table we added support for multiple tables.

    If you want you can already use these functions by installing the library from main or from the multi_table branch.

  3. linked a pull request that will close this issuemulti table support #455on Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions