You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
add_table() method would be consistent w. other add_[attribute]() #451
Adding a table as follows
sdata.table = myTable
is inconsistent with the method for adding images, labels, points and shapes. I feel like an add_table method would be clearer.
changed the title [-]add_table method would be consistent w. other add_[attribute][/-][+]add_table() method would be consistent w. other add_[attribute]()[/+]on Feb 6, 2024
Thanks @MichielVerCruysse for reporting this. We actually fixed this inconsistency but we haven't made a release yet. It will probably take a few more weeks until we cut one.
Activity
[-]add_table method would be consistent w. other add_[attribute][/-][+]add_table() method would be consistent w. other add_[attribute]()[/+]LucaMarconato commentedon Feb 6, 2024
Thanks @MichielVerCruysse for reporting this. We actually fixed this inconsistency but we haven't made a release yet. It will probably take a few more weeks until we cut one.
We took another approach: in #329 we remove the
add_image(),add_labels(), ... methods and in the branch https://github.com/scverse/spatialdata/tree/multi_table we added support for multiple tables.If you want you can already use these functions by installing the library from
mainor from themulti_tablebranch.