Repository navigation
Refactoring query functions #225
Description
There are multiple ways (some still to be implemented) to subset/query a SpatialData object. Some of these methods are living outside this repo. We need to port them here and use a more consistent syntax (for instance always sdata.query.query_method).
- spatial query (bounding box query):
sdata.query.bounding_box() - spatial query (general polygon): not implemented yet
- query by obs: implemented in
napari-spatialdata, branchspatialdata - query by var: not implemented yet
- query by coordinate system:
sdata.filter_by_coordinate_system() - query by (a list of) element names: implemented in
spatialdata-plot
Reacted by Tim Treis
Activity
[-]refactoring query functions[/-][+]Refactoring query functions[/+]kevinyamauchi commentedon Apr 13, 2023
Currently, the
bounding_box_querydoesn't automatically filter for elements within the target coordinate system. I think we should add that. We could just add a call tofilter_by_coordinate_systemto the beginning of the query. Thoughts?LucaMarconato commentedon Jan 9, 2024
Also:
SpatialData.subset()LucaMarconato commentedon Feb 1, 2024
Another point to consider, as observed in #443 (comment), is that query functions that appear only as methods of
SpatialDatamaybe be a bit hidden in the docs.