Skip to content

Coordinates in .obsm['spatial'] in Tables getting out of sync after transformations. #123

Closed

Description

@LucaMarconato

In the design doc we mention the possibility to store the centroids for labels and the centroids for graphs in the associated table, storing them with the intrinsic coordinate system. These coordinates could get out of sync after applying some transformations (for instance a cropping). We could take care of them and update them when we apply a transformation.

Activity

  1. giovp commented on Feb 2, 2023

    @giovp
    Member

    agree, I think the cropping and subsetting that is done at the spatialdata level should handle that. If the element is cropped outside spatialdata then I don't think we can give much guarantee

  2. LucaMarconato commented on Feb 22, 2024

    @LucaMarconato
    MemberAuthor

    I believe the best is to have a new points layer, for instance the one returned from the new get_centroids() API. In this way there is no problem of getting out-of-sync because points are supported by the coordinate systems mechanism.

    We should remove the references to obsm['spatial'] in the design doc.

  3. LucaMarconato commented on Mar 18, 2024

    @LucaMarconato
    MemberAuthor

    Updating the design doc now (removing obsm['spatial']) and closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions