Repository navigation
fix: drop MAML2-NOTCH entries from the consensus resource - #247
Merged
dbdimitrov merged 1 commit intoAug 20, 2026
Merged
Conversation
MAML2 is a nuclear transcriptional co-activator, not a secreted or membrane ligand. The MAML2-NOTCH1/2/3/4 rows in omni_resource.csv were a curation artifact: the real interaction is between the cleaved intracellular domain of NOTCH and MAML2 inside the nucleus, not a ligand-receptor pair at the cell surface. Removes the four rows and updates the consensus resource count test, plus adds a regression test so MAML2 can't creep back into a future curation pass. Fixes scverse#207
Contributor
Author
|
Gentle nudge on this one whenever you have a moment. It only removes the four MAML2-NOTCH rows Rob flagged and adds a test to keep them out, so it should be a safe drop-in until the full resource revamp lands. Happy to rebase if it has gone stale. |
Merged
Contributor
Author
|
Thanks for merging both, @dbdimitrov. If the resource revamp turns up more rows like the MAML2-NOTCH ones, glad to take a pass at those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207
MAML2 is a nuclear transcriptional co-activator, not a secreted or membrane-bound ligand. The interaction NOTCH signaling actually involves is between the cleaved intracellular domain of the NOTCH receptor and MAML2 inside the nucleus, regulating transcription, not a cell-surface ligand-receptor pair. The four MAML2-NOTCH1/2/3/4 rows in
omni_resource.csvtaggedconsensuslook like a curation artifact from the same process discussed in #177.Removed the four rows, updated the
test_select_resourcecount (4624 to 4620), and addedtest_consensus_resource_excludes_maml2as a regression check.Tested
tests/test_select_resource.pyandtests/test_orthology.pyin a fresh Python 3.12 container: 9/9 passing.