You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6d6e0b5
Browse filesBrowse the repository at this point in the historyBrowse files
fork-tests: fix round 1 (secret scan range, every test run, one commit per run, drift)
Secret scan (.github/scripts/fork-secret-scan.sh, tests: fork-secret-scan.test.sh)
- Pull requests scan base.sha..head.sha on a full blob-less clone instead of the
newest N commits by date. After a merge of main, the PR's oldest commits fell
outside --max-count and were never scanned; a squash merge never brings them to
main, yet they stay public under refs/pull/N/head.
- Merge commits are diffed with --remerge-diff. Plain `git log -p` shows merges
with no diff, so a key added only in a merge commit was never read.
- Push: before..after; a force push scans what the new tip has and the old one
had not. A new branch, or an old tip that cannot be fetched, scans only the
pushed commit and says so in a warning.
- The Secret scan job runs the test against the pinned gitleaks before scanning.
Every test file under .github/scripts runs somewhere (fork-ci-tests.cjs)
- Finds *.test.* in subdirectories too. Runs .sh, .py, .cjs, .mjs and .js; a
listed test with another extension fails instead of being skipped.
- Upstream's tests are listed as "<test> run by <file>"; the file must name the
test and cannot be a disabled upstream workflow. thread-transfer-report.test.cjs
was run nowhere (upstream runs it from a workflow_run of its disabled CI); Test 1
runs it now with upstream's other release-check tests.
One commit per release run
- `changes` resolves a workflow_dispatch/workflow_call ref to a SHA once; every
job checks that out, so a branch that moves mid-run cannot split a run over two
commits. workflows, lint and the server shards now wait for `changes`.
Upstream drift (fork-tests-drift.cjs)
- Also digests the top-level env, defaults, concurrency and permissions.
- --record refuses (exit 1) while a tracked job is missing instead of saving
null, and an old null entry is reported instead of crashing.
- --record prints the upstream changes it accepts; the commit and PR must say
what was ported for each.
Re-recorded .github/fork-tests-upstream.json. It accepts:
- ci.yml top-level permissions (contents: read): fork-tests.yml has the same.
- ci.yml top-level concurrency (group per PR/sha, cancel on pull_request):
fork-tests.yml has the equivalent, with the event name in the group.
- release.yml top-level concurrency and permissions: they apply to upstream's
release run, not its test jobs. fork-release.yml has its own.
No job or step changed upstream.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments