Migrate the Compiler to use the new API #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
compiler
branch
4 times, most recently
from
afe7238 to
b0fe0df
Compare
stof
force-pushed
the
compiler
branch
4 times, most recently
from
f3cb7ae to
3a015de
Compare
This was referenced Sep 9, 2024
stof
force-pushed
the
compiler
branch
4 times, most recently
from
2a90b41 to
812bc2b
Compare
This is not supported anymore.
This hardcodes a string using the legacy value representation instead of using the ValueConverter to produce it, because the ValueConverter will be updated to return the modern representation instead.
This allows to have an output matching the dart-sass logger exactly. The AdaptingLogger cannot achieve it due to the handling of the semi-colon after the warning prefix, which does not match the legacy logger when a location is available.
The expected outputs are now valid also for dart-sass.
Throwing a SassScriptException is wrong as those APIs are not used in an expression context where those exceptions are turned into SassException.
- Skip sass-spec tests which are ignored for dart-sass - Remove the input parsing in SassSpecTest - Normalize output like the official spec runner - Remove the code allowing quote differences as we now match the upstream formatting for strings. - Configure the current working directory as done in the official spec runner when running tests.
We know run the original tests when running sass-spec as we don't have a difference in the formatting of the output anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
Relates to #145 (the future becomes close)
Closes #237
Closes #316
Closes #266
Closes #641 (when using the new Value API to build the values)
This migration resolves lots of spec compliance issues (which is the main reason for this rewrite, so that's good).
Closes #706
Closes #688
Closes #671
Closes #648
Closes #634
Closes #625
Closes #624
Closes #606
Closes #605
Closes #512
Closes #504
Closes #469
Closes #463
Closes #404
Closes #377
Closes #376
Closes #291
Closes #285
Closes #284
Closes #283
Closes #282
Closes #281
Closes #280
Closes #279
Closes #247
Closes #220
Closes #157
Closes #147
Closes #146