Fix bootstrap compilation #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b57452. Being strictly compliant in the implementation of nth and setNth is actually breaking things due to our non-compliant lists
|
It is working now, thanks for your support! |
Member
Author
I know it is: I added it in the CI as part of the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #403
This reverts #380. fixing spec compliance for lists to avoid breaking list functions is too much work, as it looks like it requires fixing interpolation first.
As Bootstrap seems to compile fine without the
nthrefactoring (even though some other list-related code might have bugs that we already had in 1.4 due to not being spec compliant), I prefer delaying the spec compliance fix to a 2.x release rewriting the parser.