Upgrade sass-spec #217
Merged
Upgrade sass-spec #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
commented
Oct 31, 2020
| libsass/div | ||
| libsass/env | ||
| libsass/features/extend-selector-pseudoclass | ||
| libsass/features/global-variable-shadowing |
Member
Author
There was a problem hiding this comment.
These removals are not about increased compliance on our side. It is just that I identified the libsass/features/* specs as being duplicates of core_functions/meta/feature-exists/* ones and I removed them upstream.
| core_functions/selector/unify/simple/universal/and_universal/explicit/and_default | ||
| core_functions/selector/unify/simple/universal/and_universal/explicit/and_empty | ||
| core_functions/string/index/combining_character | ||
| core_functions/string/index/double_width_character |
Member
Author
There was a problem hiding this comment.
These 2 failed specs are actually specs that I contributed myself upstream to cover a potential issue in our code (and this proves that we are indeed affected).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.