Fix clippy warnings #851
Merged
Fix clippy warnings #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that get the newest clippy warnings
…manually from most builds
Niederb
added
F3-test
haerdib
approved these changes
Jun 4, 2025
Contributor
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
Thank you very much for the effort! It looks good, apart from one question
.github/workflows/ci.yml
Outdated
| cargo clippy -p substrate-api-client -- -D warnings, | ||
| cargo clippy -p substrate-api-client --no-default-features -- -D warnings, | ||
| cargo clippy -p substrate-api-client --all-features --examples -- -D warnings, | ||
| cargo clippy --workspace --exclude ac-keystore --exclude test-no-std -- -D warnings, |
Contributor
There was a problem hiding this comment.
Is the exclude ac-keystore still necessary?
Contributor
Author
There was a problem hiding this comment.
Yeah, you are right. I removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run and build the complete workspace. Also update the toolchain such that I get the newest clippy warnings
sync-apifeature being active and then clippy does not manage to compile the featureskeystoreafter all. I could not manage to tell clippy to ignore the crate in all cases.