Implement state handling for Retracted status #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide is_final method for TransactionStatus - Return from watch method as soon as a final state is reached - Provide separate method to populate events for an ExtrinsicReport
Niederb
added
E2-breaksapi
F7-enhancement
haerdib
reviewed
Oct 9, 2024
haerdib
reviewed
Oct 24, 2024
src/api/mod.rs
Outdated
| /// Returns an error if the events are missing or if one of the events indicates a problem. | ||
| pub fn status_based_on_events(&self, metadata: &Metadata) -> Result<()> { | ||
| if self.events.is_none() { | ||
| return Err(Error::Other("Report does not contain any events".into())) |
Contributor
There was a problem hiding this comment.
Would it make sense adding an extra Error Type like NoEvent (or something alike) instead of using Other?
Contributor
Author
There was a problem hiding this comment.
👍 I added two error types for event related errors
haerdib
approved these changes
Oct 28, 2024
Contributor
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
LGTM, thank you very much for your patience! Only one change suggestion left, but you can go on without it as well.
Co-authored-by: Bigna Härdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnexpectedTxStatustoXtStatusTransactionStatusExtrinsicReport