-
Notifications
You must be signed in to change notification settings - Fork 127
Examples: switch to use rococo node #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Niederb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes. I think it makes sense to use the rococo runtime as this one should be better maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have documentation on how to get this file and what version this currently is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built it myself. But effectively it can be any runtime, as long as the spec_version is higher than the original one and the runtime name matches the old one. I only took the minimal one to make sure it builds faster.
Should I add a documentation for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have some documentation 👍
|
|
||
| println!("[+] Alice's Account Nonce is {}", api.get_nonce().await.unwrap()); | ||
|
|
||
| let wasm = include_bytes!("flipper.wasm").to_vec(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think flipper.wasm is not used anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
Niederb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for the updated documentation 👍
This PR updates the following:
../latest. The dev runtime is rococo.rococo_runtime_configa little bit more comprehensible / traceable.Reasoning: Staking and contracts pallet are not available on the Rococo runtime. The Identity pallet is available, but the calls are filtered: https://github.com/paritytech/polkadot-sdk/blob/cc7ebe054038186c8a7409f54c4008ddc82a5ad0/polkadot/runtime/rococo/src/lib.rs#L189-L198
closes #778