Skip to content

Fix taplo issue in nightly build #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Niederb merged 1 commit into from
Jul 30, 2024
Merged

Fix taplo issue in nightly build #795

Niederb merged 1 commit into from
Jul 30, 2024

Conversation

@Niederb
Copy link
Contributor

@Niederb Niederb commented Jul 30, 2024 •
edited
Loading

The nightly build is currently failing due to a regression in taplo. Taplo is re-ordering keys alphabetically.
Error message:

2024-07-30T00:11:48.6950177Z  INFO taplo:format_files:load_config: found configuration file path="/__w/substrate-api-client/substrate-api-client/.taplo.toml"
2024-07-30T00:11:48.6985816Z  INFO taplo:format_files:collect_files: found files total=11 excluded=0 cwd="/__w/substrate-api-client/substrate-api-client"
2024-07-30T00:11:48.7139599Z ERROR taplo:format_files: the file is not properly formatted path="/__w/substrate-api-client/substrate-api-client/Cargo.toml"
2024-07-30T00:11:48.7179071Z ERROR taplo:format_files: the file is not properly formatted path="/__w/substrate-api-client/substrate-api-client/compose-macros/Cargo.toml"
2024-07-30T00:11:48.7314803Z ERROR taplo:format_files: the file is not properly formatted path="/__w/substrate-api-client/substrate-api-client/keystore/Cargo.toml"
2024-07-30T00:11:48.7441290Z ERROR taplo:format_files: the file is not properly formatted path="/__w/substrate-api-client/substrate-api-client/node-api/Cargo.toml"
2024-07-30T00:11:48.7547775Z ERROR taplo:format_files: the file is not properly formatted path="/__w/substrate-api-client/substrate-api-client/primitives/Cargo.toml"
2024-07-30T00:11:48.7686516Z ERROR taplo:format_files: the file is not properly formatted path="/__w/substrate-api-client/substrate-api-client/test-no-std/Cargo.toml"
2024-07-30T00:11:48.7776693Z ERROR operation failed error=some files were not properly formatted
2024-07-30T00:11:48.7820420Z ##[error]Process completed with exit code 1.

Solution: Prevent taplo from re-ordering keys in the package section. Taken from tamasfe/taplo#634 (comment)

@Niederb Niederb self-assigned this Jul 30, 2024
@Niederb Niederb marked this pull request as ready for review July 30, 2024 06:42
@Niederb Niederb requested a review from masapr July 30, 2024 06:42
masapr
masapr approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Niederb Niederb merged commit c609c8e into master Jul 30, 2024
@Niederb Niederb deleted the tn/fix-taplo-issue branch December 9, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masapr masapr masapr approved these changes

Assignees

@Niederb Niederb

Labels

E1-breaksnothing F3-test fix tests or CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Niederb @masapr