Skip to content

Use stabilized chainSpec calls in unstable_rpc_api_calls #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Niederb merged 2 commits into from
Jun 27, 2024
Merged

Use stabilized chainSpec calls in unstable_rpc_api_calls #783

Niederb merged 2 commits into from
Jun 27, 2024

Conversation

@Niederb
Copy link
Contributor

@Niederb Niederb commented Jun 26, 2024 •
edited
Loading

This is a quick fix to get the test working again. I created a follow up issue to provide an actual API for the functionality in the unstable_rpc_api_calls.rs test. See #779

In this PR:

  • Use stabilized versions of chainSpec calls
  • Use newer docker image (From 01.11.2023)

@Niederb
- Use newer docker image
db943dd 
- Use stabilized versions of chainSpec calls
@Niederb Niederb marked this pull request as ready for review June 26, 2024 14:09
@Niederb Niederb requested a review from masapr June 26, 2024 14:12
masapr
masapr approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Niederb Niederb merged commit ed9cef3 into master Jun 27, 2024
@Niederb Niederb deleted the tn/chainState-calls-stabilized branch December 9, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masapr masapr masapr approved these changes

Assignees

No one assigned

Labels

E1-breaksnothing F3-test fix tests or CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Niederb @masapr