Wasm test #772
Merged
Wasm test #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niederb
force-pushed
the
tn/wasm-example-test
branch
from
8b4edc0 to
443acd4
Compare
masapr
requested changes
Jul 1, 2024
Collaborator
masapr
left a comment
masapr
left a comment
There was a problem hiding this comment.
Thanks! Looks like a good first step. Only one minor comment on the yml.
| nc -z -v 127.0.0.1 9944 | ||
| chmod +x ${{ matrix.example }} | ||
| ./${{ matrix.example }} | ||
| wasm_examples: |
Collaborator
There was a problem hiding this comment.
I would add a newline before this, or even put this block below the next block "merge", as the merge is using only the examples. I'm almost wondering if we should put the wasm-stuff into its own yml-file (?). But I leave this up to you
Contributor
Author
There was a problem hiding this comment.
I added the newline. The merge is actually also for the wasm-example as this can also be downloaded. I also updated the merge to reflect this.
Niederb
force-pushed
the
tn/wasm-example-test
branch
from
443acd4 to
4d22b57
Compare
This reverts commit 6900574.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly scaffolding to have a WebAssembly test in the build. The test itself is not yet super meaningful, but I think it is still a good first step to have something running and tested.
For a proper test with real use-cases we need to investigate how to create outside connections. See #769