Rpc-clients: Add creation function with separate address and port #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
added
F7-enhancement
haerdib
changed the title
haerdib
changed the title
masapr
approved these changes
Feb 19, 2024
Collaborator
masapr
left a comment
masapr
left a comment
There was a problem hiding this comment.
Added some feedback on testing. But generally good enough this way, so I approve.
src/rpc/tungstenite_client/client.rs
Outdated
|
|
||
| let client2 = TungsteniteRpcClient::with_default_url(1); | ||
|
|
||
| assert_eq!(client.url, client2.url); |
Collaborator
There was a problem hiding this comment.
strictly speaking: your testing 2 things, not 1 (and one should ideally test only 1 thing). Apart from testing the new function "with_default_url" you're also testing, that the default port is 9944. Also, what happens if both have an error in their logic? I would check the actual string value.
Contributor
Author
There was a problem hiding this comment.
Adapted in 9c580cc. Is this what you expected?
src/rpc/ws_client/client.rs
Outdated
|
|
||
| let client2 = WsRpcClient::with_default_url(); | ||
|
|
||
| assert_eq!(client.url, client2.url); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function
new_with_portto each rpc-client which concatenates the address and the port into one string.closes #109