Fix compile errors of stand-alone features #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niederb
reviewed
Nov 28, 2023
Contributor
Niederb
left a comment
Niederb
left a comment
There was a problem hiding this comment.
I don't quite understand why the changes with Box are needed. I assume you had compilation errors. Can you tell me how I can reproduce them?
#[cfg(not(feature = "sync-api"))]
use alloc::boxed::Box;
Contributor
Author
|
See the PR description:
For reproducing: Simply remove the |
Niederb
approved these changes
Nov 28, 2023
Contributor
Niederb
left a comment
Niederb
left a comment
There was a problem hiding this comment.
Now I understood. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the compile errors of standalone features. The following was changed:
futures-utilto default import because the async code needs it to compile. Because the sync code does not, I only added the minimum needed package (which is -util and not the fullfutures).tungstenite-clientandws-clientnow include thesync-apifeature, because they are only work in sync mode anyway.#[cfg(not(feature = "sync-api"))] use alloc::boxed::Box;: async-trait automatically changes async return values into boxed values.closes #644