Add trait bounds to config: Index: Default, BlockNumber: AtLeast32BitsUnsigned
#648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
changed the title
Config: Index: Default, BlockNumber; AtLeast32BitsUnsignedConfig: Index: Default, BlockNumber: AtLeast32BitsUnsigned
clangenb
changed the title
Config: Index: Default, BlockNumber: AtLeast32BitsUnsignedIndex: Default, BlockNumber: AtLeast32BitsUnsigned
haerdib
approved these changes
Sep 25, 2023
Contributor
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
That makes sense to me. Thanks for helping out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like reasonable assumptions for me, and they made my code in the worker a bit more ergonomic. :)
Config::Indextype should have default trait bound #646