Rename runtime configs to something more generic #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
reviewed
Jul 5, 2023
| @@ -17,9 +17,9 @@ use core::fmt::Debug; | |||
|
|
|||
| /// Default set of commonly used types by Substrate kitchensink runtime. | |||
| #[derive(Decode, Encode, Clone, Eq, PartialEq, Debug)] | |||
| pub struct SubstrateKitchensinkConfig {} | |||
Contributor
There was a problem hiding this comment.
Cool, thanks a lot! To avoid a lot of confusion: What would you think about defining a "new" type that has the same name as the old one, but marked with a deprecated?
E.g.
#[deprecated(since="0.14.0", note="Please use `AssetRuntimeConfig` instead, this will be removed in the next release.")]
pub type SubstrateKitchensinkConfig = AssetRuntimeConfig;Same for the PolkadotConfig.
Contributor
There was a problem hiding this comment.
Not sure if the "since" works for future releases, but it would certainly help us to note how old the deprecated text is and when to remove it.
echevrier
force-pushed
the
ec/rename_runtime_configs
branch
from
b38528d to
3abbcc2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename SubstratKitchensinkConfig into AssetRuntimeConfig
Rename PolkadotConfig into DefaultRuntimeConfig
Close ##586