fetch more storage keys than the maximum limit set by substrate #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niederb
reviewed
Jul 3, 2023
Contributor
Niederb
left a comment
Niederb
left a comment
There was a problem hiding this comment.
I'm not quite sure if it makes sense to have get_all_storage_keys_paged_up_to_count as a separate function. It can do everything that get_storage_keys_paged can, so for me it should become the new get_storage_keys_paged and get_storage_keys_paged could become an internal helper method.
haerdib
reviewed
Jul 3, 2023
Contributor
Author
We provide both methods. See: #588 (comment) |
added 6 commits
July 4, 2023 10:37
…f keys, independantly of substrate limit
echevrier
force-pushed
the
ec/fetch_all_pages_fix
branch
from
c4973d0 to
8444dfc
Compare
haerdib
reviewed
Jul 4, 2023
haerdib
approved these changes
Jul 5, 2023
| /// If `start_key` is passed, return next keys in storage in lexicographic order. | ||
| /// | ||
| /// `at_block`: the state is queried at this block, set to `None` to get the state from the latest known block. | ||
| // See https://github.com/paritytech/substrate/blob/9f6fecfeea15345c983629af275b1f1702a50004/client/rpc/src/state/mod.rs#L54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get_all_storage_keys_paged_up_to_count to fetch required number of keys, independantly of substrate limit:
The default call, get_storage_keys_paged performs according to substrate: if required number of keys> 1000, an error is thrown. The documentation warns the user.
This does not completely fix #588. To fetch all pages, you need to know how many keys are stored. Currently,
countis mandatory instate_getKeysPagedand substrate doesn't support the feature for obtaining all keys.