Skip to content

Take Bytes parameters as borrow #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Niederb merged 3 commits into from
Jul 3, 2023
Merged

Take Bytes parameters as borrow #601

Niederb merged 3 commits into from
Jul 3, 2023

Conversation

@Niederb
Copy link
Contributor

@Niederb Niederb commented Jun 29, 2023 •
edited
Loading

Take Bytes parameters by reference. Makes the code a bit more idiomatic and efficient.
We mostly use it for serialization and this works fine as it is also implemented for the reference.

@Niederb Niederb added F6-optimization This should optimize the performance E2-breaksapi labels Jun 29, 2023
@Niederb Niederb self-assigned this Jun 29, 2023
@Niederb Niederb linked an issue Jun 29, 2023 that may be closed by this pull request
Add borrow to Bytes #582
Closed
@Niederb Niederb removed the F6-optimization This should optimize the performance label Jun 30, 2023
@Niederb Niederb requested review from echevrier and haerdib June 30, 2023 08:15
echevrier
echevrier approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

haerdib
haerdib approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Yeesss, thanks a lot!

@Niederb Niederb merged commit ca71c0c into master Jul 3, 2023
@Niederb Niederb deleted the tn/borrow-bytes branch July 17, 2023 08:47
@haerdib haerdib added the F6-optimization This should optimize the performance label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haerdib haerdib haerdib approved these changes

@echevrier echevrier echevrier approved these changes

Assignees

@Niederb Niederb

Labels

E2-breaksapi F6-optimization This should optimize the performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add borrow to Bytes

4 participants

@Niederb @haerdib @echevrier