Evaluate named arg. values in caller context#652
Merged
xoofx merged 4 commits intoscriban:masterfrom Mar 12, 2026
Merged
Conversation
xoofx
reviewed
Mar 12, 2026
Member
Could you also add a test case for this? |
Member
|
Thank you for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the fix in #649, it looks a lot cleaner now.
#649 moved the evaluation of the named argument values to after
PushLocalwhich caused the wrong values to be passed down in some cases. This PR evaluates the values before thePushLocaland then sets the local values after it. Mimicking the functionality of #643 but now a lot cleaner thanks to #649