Fix Include named arg values being lost for nested includes#643
Merged
xoofx merged 1 commit intoscriban:masterfrom Mar 5, 2026
Merged
Fix Include named arg values being lost for nested includes#643xoofx merged 1 commit intoscriban:masterfrom
Include named arg values being lost for nested includes#643xoofx merged 1 commit intoscriban:masterfrom
Conversation
Member
|
Yeah, it's a feature that I have never used so I'm not surprised that it has several issues. Thank you for investigating them. |
Contributor
Author
|
Yeah, hopefully that's the last of the named arg issues 😅🤞, this one had me spinning for a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named argument values weren't being restored correctly if the same arg. name was being used for nested includes.
This PR includes a test case and a fix for the issue.