(Note - I'm not the maintainer of Scriban - just another occasional contributer)

You beat me to it!

While you're at it, I have a suggestion, if you have the time...

Add an overload for the normal equals method that accepts StringComparison.

Could also do that for all of the other methods, where the .NET method also accepts StringComparison.

IIRC, Scriban supports optional parameters, so it would be as easy as copy/pasting the StringComparison parameter in three places for each method:

• Parameter list
• Method call
• XML docs

If Scriban doesn't support optional parameters, then.... Maybe I'll add that?

I considered making general equals builtin function with StringComparison type parameter but I decided to make the EqualsIgnoreCase function instead, since case sensitive comparison can be accomplished using == operator and I found making equals unnecessary.

However, I think I may add an optional parameter to such functions, like StartsWith or Contains. I will wait for @xoofx 's answer to ensure if this PR makes sense according to him.

Adding string.equals_ignore_case is fine. Tests are failing (but due to the flood of logs, can't see it easily in GitHub, you need to check this locally)

I would prefer not to change existing methods. For 6+ years nobody has been looking for configurable string comparisons, so this is not necessary to change all these. Users can always create custom methods on their side.

Pull Request Test Coverage Report for Build 5229987164

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 78.586%

Totals
Change from base Build 4852412395:	0.03%
Covered Lines:	11564
Relevant Lines:	13962

💛 - Coveralls