Fix apparent regression on Evaluate#342
Merged
xoofx merged 2 commits intoscriban:masterfrom Apr 30, 2021
Merged
Conversation
Member
|
Good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #336 which appears to have been introduced with commit d77a237 "Improve handling of top-level evaluation with enumeration"
The issue was that the test for IEnumerable snags strings (which are IEnumerable of chars) and recasts them to ScriptArrays of chars
Not sure if there are any other relevant types that can present as IEnumerable - string was the only one I could think of off the top of my head?