Fixes a potential stack overflow if the object graph contains cycles#340
Merged
xoofx merged 1 commit intoscriban:masterfrom Apr 17, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unfortunately quite easy to create cyclical object graphs in TextrudeInteractive since the script is re-rendered after each keystroke. For example, en-route to typing
model.newProperty=model.a+model.bthe user will, at some point, have a line readingmodel.newProperty=model. If this is then rendered to a string, Scriban will throw an uncatchable StackOverflowException as it repeatedly traversesTemplateContext.ObjectToStringandScriptObject.ToString.This change introduces an
ObjectRecursionLimitproperty onTemplateContextwhich is checked against the existing_objectToStringLevelfield. It defaults to 0 (i.e disabled) to preserve the old behaviour unless explicitly set.