Implement some missing interface methods.#326
Merged
xoofx merged 1 commit intoscriban:masterfrom Feb 1, 2021
Merged
Conversation
ScriptObject got a more efficient implementation of IEnumerator`2.GetEnumerator, a correct implementation of ICollection`1.IsReadOnly and non-throwing implementations of four ICollection members (`CopyTo` in particular is used by Rider's debugger and hindered debugging experience by throwing). Furthermore ScriptRange's IList.Remove was trivially implemented.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScriptObject got a more efficient implementation of
IEnumerator`2.GetEnumerator, a correct implementation ofICollection`1.IsReadOnlyand non-throwing implementations of fourICollection`1members (CopyToin particular is used by Rider's debugger and hindered debugging experience by throwing).Furthermore
ScriptRange'sIList.Removewas trivially implemented.