Fix pipe argument docs

xoofx · Copilot · xoofx · commit 4cb135ab021f · 2026-03-21T10:41:27.000+01:00
Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/issue-followup-plan.md b/issue-followup-plan.md
@@ -2,9 +2,11 @@
 
 This cleanup pass closed 55 old issues that were stale, already answered, resolved in current Scriban, or outside the scope of core Scriban.
 
-Issues `#625`, `#453`, and `#529` are fixed locally by the changes in this pass.
+Issues `#625`, `#453`, `#529`, and `#209` are fixed locally by the changes in this pass.
 
-The 8 issues below remain open because they were either reproduced on current head, still point to incorrect documentation, or need an explicit design decision before any code change is worth doing.
+Issue `#553` is being closed without a code change because `{{~ ... }}` shows the same indentation-trimming behavior at top level, so this does not appear to be a caller-indent regression specific to function rendering.
+
+The 6 issues below remain open because they need an explicit design decision before any code change is worth doing, or are low-priority cleanup items better closed later.
 
 Default stance for the next pass:
 
@@ -14,35 +16,8 @@ Default stance for the next pass:
 
 ## 1. Concrete docs and bug fixes
 
-### #553 Whitespace control inside of functions affects auto-indent of caller
-
-Status: reproduced.
-
-Evidence:
-
-- `{{~ ... }}` inside a called function still perturbs the caller's auto-indent/output layout.
-
-Suggested action:
-
-- Isolate callee whitespace trimming from caller indentation state.
-- Add regression tests for function calls with and without `{{~ ... }}` inside the callee body.
-
 ## 2. Docs cleanup that should be narrowed
 
-### #209 Is the documentation out of date?
-
-Status: still broadly true, but too broad.
-
-Evidence:
-
-- `site/docs/runtime/scriptobject.md` still says pipe calls pass the previous value as the last argument, which is outdated or at least misleading.
-- #625 is another concrete example of doc drift.
-
-Suggested action:
-
-- Either narrow this issue to a short checklist of specific doc fixes or close it after fixing the concrete doc items already identified.
-- Do not leave this as a permanent catch-all docs issue.
-
 ## 3. Feature and design decisions before implementation
 
 ### #188 array.sort only works with simple members (can't use nested members)
@@ -130,10 +105,8 @@ Suggested action:
 
 ## Suggested review order
 
-1. #553
-2. #209
-3. #188 and #405 together
-4. #368
-5. #513
-6. #284
-7. #446
+1. #188 and #405 together
+2. #368
+3. #513
+4. #284
+5. #446
diff --git a/site/docs/runtime/scriptobject.md b/site/docs/runtime/scriptobject.md
@@ -107,8 +107,8 @@ This function can be imported into a ScriptObject:
   Console.WriteLine(result);
   ```
 
-> Notice that when using a function with pipe calls like `{{ "{{" }}description | string.strip {{ "}}" }}`, the last argument passed to the `string.strip` function is the result of the previous pipe.
-> That's a reason why you will notice in all builtin functions in scriban that they usually take the most relevant parameter as a last parameter instead of the first parameter, to allow proper support for pipe calls.
+> Notice that when using a function with pipe calls like `{{ "{{" }}description | string.strip {{ "}}" }}`, the result of the previous pipe becomes the first explicit argument passed to `string.strip`.
+> For example, `{{ "{{" }} date | format "dd.MM" {{ "}}" }}` calls `format(date, "dd.MM")` (or `format(context, date, "dd.MM")` for methods that declare a leading `TemplateContext`).
 
 > **NOTICE**
 >
diff --git a/src/Scriban.Tests/TestRuntime.cs b/src/Scriban.Tests/TestRuntime.cs
@@ -609,6 +609,14 @@ public static string T(TemplateContext context, object input, params object[] va
             }
         }
 
+        public static class ImportedPipeOrderFunctions
+        {
+            public static string Format(DateTime input, string formatString)
+            {
+                return input.ToString(formatString, CultureInfo.InvariantCulture);
+            }
+        }
+
         [Test]
         public void TestFunctionArrayEachAndFunctionCall()
         {
@@ -760,6 +768,26 @@ public void TestFunctionWithTemplateContextAndObjectParams()
             }
         }
 
+        [Test]
+        public void TestImportedFunctionPipeValueUsesFirstArgument()
+        {
+            var template = Template.Parse(@"{{ date | format ""dd.MM"" }}");
+            Assert.False(template.HasErrors);
+
+            var context = new TemplateContext();
+            var scriptObject = new ScriptObject();
+            scriptObject.Import(typeof(ImportedPipeOrderFunctions));
+            context.PushGlobal(scriptObject);
+            context.PushGlobal(new ScriptObject
+            {
+                ["date"] = new DateTime(2024, 2, 3),
+            });
+
+            var result = template.Render(context);
+
+            Assert.AreEqual("03.02", result);
+        }
+
         [Test]
         public void TestInvalidConvertToInt()
         {

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,8 @@ This function can be imported into a ScriptObject:`
`107`	`107`	`Console.WriteLine(result);`
`108`	`108`	```
`109`	`109`
`110`		-> Notice that when using a function with pipe calls like `{{ "{{" }}description \| string.strip {{ "}}" }}`, the last argument passed to the `string.strip` function is the result of the previous pipe.
`111`		`-> That's a reason why you will notice in all builtin functions in scriban that they usually take the most relevant parameter as a last parameter instead of the first parameter, to allow proper support for pipe calls.`
	`110`	+> Notice that when using a function with pipe calls like `{{ "{{" }}description \| string.strip {{ "}}" }}`, the result of the previous pipe becomes the first explicit argument passed to `string.strip`.
	`111`	+> For example, `{{ "{{" }} date \| format "dd.MM" {{ "}}" }}` calls `format(date, "dd.MM")` (or `format(context, date, "dd.MM")` for methods that declare a leading `TemplateContext`).
`112`	`112`
`113`	`113`	`> NOTICE`
`114`	`114`	`>`