Clear include cache on TemplateContext.Reset

xoofx · Copilot · xoofx · commit 099cb0491df9 · 2026-03-21T07:17:59.000+01:00
Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/src/Scriban.Tests/TestIncludes.cs b/src/Scriban.Tests/TestIncludes.cs
@@ -73,6 +73,48 @@ public ValueTask<string> LoadAsync(TemplateContext context, SourceSpan callerSpa
             }
         }
 
+        private sealed class SwitchingLoader : ITemplateLoader
+        {
+            public string Content { get; set; } = string.Empty;
+
+            public string GetPath(TemplateContext context, SourceSpan callerSpan, string templateName)
+            {
+                return templateName;
+            }
+
+            public string Load(TemplateContext context, SourceSpan callerSpan, string templatePath)
+            {
+                return Content;
+            }
+
+            public ValueTask<string> LoadAsync(TemplateContext context, SourceSpan callerSpan, string templatePath)
+            {
+                return ValueTask.FromResult(Load(context, callerSpan, templatePath));
+            }
+        }
+
+        [Test]
+        public void ResetShouldClearCachedTemplates()
+        {
+            var loader = new SwitchingLoader { Content = "admin-only" };
+            var context = new TemplateContext
+            {
+                TemplateLoader = loader
+            };
+            var template = Template.Parse("{{ include 'profile' }}");
+
+            var first = template.Render(context);
+            Assert.AreEqual("admin-only", first);
+            Assert.That(context.CachedTemplates, Does.ContainKey("profile"));
+
+            context.Reset();
+            loader.Content = "guest-view";
+
+            var second = template.Render(context);
+            Assert.AreEqual("guest-view", second);
+            Assert.That(context.CachedTemplates, Does.ContainKey("profile"));
+        }
+
         [Test]
         public void TestIndentedNestedIncludes()
         {
@@ -557,4 +599,4 @@ public void TestIncludeJoinWithTemplateDelimiters()
             Assert.AreEqual(expectedString, template.Render(context));
         }
     }
-}
+}
diff --git a/src/Scriban/TemplateContext.cs b/src/Scriban/TemplateContext.cs
@@ -899,6 +899,8 @@ public virtual void Reset()
             {
                 PopSourceFile();
             }
+
+            CachedTemplates.Clear();
         }
 
         /// <summary>
@@ -1387,4 +1389,4 @@ public override string GetTemplatePathFromName(string templateName, ScriptNode c
             return ConvertTemplateNameToPath(templateName, callerContext);
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -899,6 +899,8 @@ public virtual void Reset()`
`899`	`899`	`{`
`900`	`900`	`PopSourceFile();`
`901`	`901`	`}`
	`902`	`+`
	`903`	`+ CachedTemplates.Clear();`
`902`	`904`	`}`
`903`	`905`
`904`	`906`	`/// <summary>`
`@@ -1387,4 +1389,4 @@ public override string GetTemplatePathFromName(string templateName, ScriptNode c`
`1387`	`1389`	`return ConvertTemplateNameToPath(templateName, callerContext);`
`1388`	`1390`	`}`
`1389`	`1391`	`}`
`1390`		`-}`
	`1392`	`+}`