Use month with 31 days to avoid test failures#1086
Merged
Gallaecio merged 1 commit intoscrapinghub:masterfrom Oct 18, 2022
Merged
Use month with 31 days to avoid test failures#1086Gallaecio merged 1 commit intoscrapinghub:masterfrom
Gallaecio merged 1 commit intoscrapinghub:masterfrom
Conversation
Codecov ReportBase: 98.23% // Head: 98.23% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 232 232
Lines 2599 2599
=======================================
Hits 2553 2553
Misses 46 46 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Gallaecio
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fails on the 31st of any month since the set month in the test doesn't have the 31st date. We fix this by using the month with 31 days.
Fixes #1053