Remove 'SetupPluginEnv' #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjenkins8
force-pushed
the
gjenkins/plugin-system/rm_setup_plugin_env
branch
from
86cbff9 to
22f5faa
Compare
Owner
|
Oh thank god. I figured this would be a post release cleanup. But happy you did this now. |
Owner
|
I'd be happy to get this into upstream before the feature freeze if we have time after the required things. But it can also be a follow-up (non-breaking) change after freeze too. |
2 tasks
gjenkins8
force-pushed
the
gjenkins/plugin-system/rm_setup_plugin_env
branch
4 times, most recently
from
b772006 to
5056552
Compare
Signed-off-by: George Jenkins <[email protected]>
gjenkins8
force-pushed
the
gjenkins/plugin-system/rm_setup_plugin_env
branch
from
5056552 to
d691452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove 'SetupPluginEnv', as this only works for subprocess plugins.
The change ended up being slightly involved, as PrepareCommands uses the processes environmental variables to expand CLI arguments. Which had to be replaced by passing in the intended child processes environment variables instead.
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)