pkg-config: datadir relative variables#198
Closed
inigomartinez wants to merge 1 commit intoscop:masterfrom
Closed
Conversation
Although `datarootdir` is defined as `${prefix}/share`, the user has
the possibility to define `datadir` in a different directory.
Due to this `completionsdir` and `helpersdir` that are defined in
the generated pkg-config `.pc` file should be relative to `datadir`
variable.
This helps any pkg-config user to set these variables to proper
directories by using the `define-variable` command line argument.
Owner
|
Applying your change would have resulted in a warning from, $ ./configure | grep WARNING
config.status: WARNING: 'bash-completion.pc.in' seems to ignore the --datarootdir setting...and there were similar potential issues in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
datarootdiris defined as${prefix}/share, the user has the possibility to definedatadirin a different directory.Due to this
completionsdirandhelpersdirthat are defined in the generated pkg-config.pcfile should be relative todatadirvariable.This helps any pkg-config user to set these variables to proper directories by using the
define-variablecommand line argument.