Skip to content

BUG: np.hstack does not accept generator expressions #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilayn merged 2 commits into from
Oct 26, 2018
Merged

BUG: np.hstack does not accept generator expressions #9405

ilayn merged 2 commits into from
Oct 26, 2018

Conversation

@ilayn
Copy link
Member

@ilayn ilayn commented Oct 25, 2018

Lately SciPy tests fail on the upstream NumPy branch. Judging by the fix that made the tests passed locally, it looks like numpy.hstack behavior changed.

Converted to list comprehension with this PR.

@ilayn ilayn added defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.optimize labels Oct 25, 2018
@ilayn ilayn added this to the 1.2.0 milestone Oct 25, 2018
@ilayn ilayn mentioned this pull request Oct 25, 2018
Closed
@ilayn ilayn changed the title FIX: np.hstack does not accept generator expressions BUG: np.hstack does not accept generator expressions Oct 26, 2018
@shoyer shoyer mentioned this pull request Oct 26, 2018
Closed
tylerjereddy
tylerjereddy approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible -- it may be that Stephan will opt to support the problematic scenario upstream in NumPy for a while, but looks like we probably don't want to depend on feeding in generators long-term.

@ilayn
Copy link
Member Author

ilayn commented Oct 26, 2018

Since the changes are rather trivial and all PRs get affected by this, I'm merging this.

@ilayn ilayn merged commit c8069fd into scipy:master Oct 26, 2018
@ilayn ilayn deleted the optimize_fix branch October 26, 2018 06:38
@larsoner
Copy link
Member

larsoner commented Oct 26, 2018

Thanks for getting us back to green @ilayn

This was referenced Oct 26, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees

No one assigned

Labels

defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.linalg scipy.optimize scipy.stats

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ilayn @larsoner @tylerjereddy