DOC: _binomtest.py: Add clearer error messages#19540
Merged
mdhaber merged 2 commits intoscipy:mainfrom Nov 16, 2023
Merged
Conversation
Print actual values if ValueErrors occur in _binomtest.py.
lucascolley
added
Documentation
mdhaber
approved these changes
Nov 16, 2023
lucascolley
requested changes
Nov 16, 2023
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
CI failures are real as there are regex tests which need to be updated.
Contributor
|
I was waiting to merge until CI passes. The changes looked fine, but I figured that some error message tests might fail. @EwoutH please adjust the appropriate tests. |
Contributor
Author
|
You guys are very fast with reviewing, thanks! I can take a look at the tests tomorrow morning (CET time), but I see you already started, which is perfect by me. |
Contributor
|
@lucascolley I went ahead and updated the tests. Care to take a look? |
lucascolley
approved these changes
Nov 16, 2023
Member
|
thanks @EwoutH ! |
Contributor
Author
|
Thanks for reviewing, updating the tests and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print actual values if
ValueErrors occur instats/_binomtest.py.