MAINT: Move trapezoid implementation to SciPy
#19100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mtsokol we already have a |
Contributor
Author
@andyfaff To explain, def trapezoid(y, x=None, dx=1.0, axis=-1):
"""..."""
return np.trapz(y, x=x, dx=dx, axis=axis)So it's only a wrapper for NumPy's function. This PR moves NumPy's implementation to Scipy, as we decided that |
andyfaff
reviewed
Aug 21, 2023
dschmitz89
added
scipy.integrate
maintenance
j-bowhay
reviewed
Aug 21, 2023
andyfaff
reviewed
Aug 21, 2023
Contributor
|
I think the cirrus ci fail is because hypothesis has only just been added to the ci config. A rebase on main would probably fix this, but I think it's mergeable as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rgommers,
One of the functions that will be deprecated and removed in numPy 2.0 is
np.trapz. It's the only integration function that still lives in NumPy instead of SciPy'sscipy.integrate. In this PR I move implementation and tests directly to SciPy to then remove the original one from NumPy.