Skip to content

Conversation

@mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Aug 11, 2023

Hi @rgommers,
Here's one follow-up work related to numpy/numpy#24357:

  • NINF that I skipped as it was imported directly instead of np.NINF
  • One add_newdoc that was also imported directly from the main namespace (in other places it's already imported from numpy.lib)

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, thanks @mtsokol.

@rgommers rgommers changed the title API: Change add_newdocs import and remove NINF MAINT: Change add_newdoc import and remove NINF Aug 11, 2023
@rgommers rgommers merged commit 5430851 into scipy:main Aug 11, 2023
@mtsokol mtsokol deleted the change-add-newdocs-import branch August 11, 2023 15:38
lucascolley pushed a commit to lucascolley/scipy that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants