Repository navigation
ENH: Update numpy exceptions imports - #19015
Merged
Merged
Conversation
mtsokol
requested review from
andyfaff,
ilayn,
larsoner and
perimosocordiae
as code owners
August 4, 2023 08:55
rgommers
added
maintenance
mtsokol
force-pushed
the
update-np-exceptions-imports
branch
from
August 4, 2023 10:22
4a4c7b8 to
979fa4e
Compare
tylerjereddy
approved these changes
Aug 5, 2023
tylerjereddy
left a comment
tylerjereddy
left a comment
Contributor
There was a problem hiding this comment.
I read the full diff, and some of the linked NumPy PR discussion, and it is straightforward to understand how this is helpful to guard against upcoming NumPy changes.
CI is also happy, so I'll go ahead and merge it in, thanks for your first contribution to SciPy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR introduces updated imports of
numpy.exceptionsdepending on NumPy version (from version 2.0, NumPy's exceptions won't be available from the main namespace). Numpy's PR: numpy/numpy#24316