Skip to content

MAINT: linalg: remove a stray np.cast - #18973

Merged
rgommers merged 1 commit into
scipy:mainfrom
ev-br:stray_np_cast
Jul 27, 2023
Merged

MAINT: linalg: remove a stray np.cast#18973
rgommers merged 1 commit into
scipy:mainfrom
ev-br:stray_np_cast

Conversation

@ev-br

@ev-br ev-br commented Jul 27, 2023

Copy link
Copy Markdown
Member

Reference issue

numpy/numpy#24144 (comment)

What does this implement/fix?

Remove a stray call to np.cast.

Additional information

Now, without looking it up: what is the result of _I = np.cast['F'](1j) ?

@ev-br ev-br added scipy.linalg maintenance Items related to regular maintenance tasks labels Jul 27, 2023
@ev-br
ev-br requested review from ilayn and larsoner as code owners July 27, 2023 13:30
@ev-br ev-br mentioned this pull request Jul 27, 2023
Merged
3 of 4 tasks
@jakevdp jakevdp mentioned this pull request Jul 27, 2023
Closed
rgommers
rgommers approved these changes Jul 27, 2023
View reviewed changes

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Evgeni.

Now, without looking it up: what is the result of _I = np.cast['F'](1j) ?

Got it wrong;) Honestly, I even had to look up dtype='F'. Always have to think hard about those letters, this should be spelled dtype=np.complex64. Also, the _I variable is only used in two places it looks like, so ideally it shouldn't have been there at all. But never mind, if needed that can be tweaked at a later date. This PR fixes the immediate issue.

@rgommers
rgommers merged commit 73c8d7b into scipy:main Jul 27, 2023
@rgommers

rgommers commented Jul 27, 2023

Copy link
Copy Markdown
Member

I also manually triggered the nightly wheel builds on main, to get a new nightly up quickly (may help JAX or scikit-learn).

@rgommers rgommers added this to the 1.12.0 milestone Jul 27, 2023
@rgommers rgommers added backport-candidate This fix should be ported by a maintainer to previous SciPy versions. and removed backport-candidate This fix should be ported by a maintainer to previous SciPy versions. labels Jul 27, 2023
@larsoner

larsoner commented Jul 27, 2023

Copy link
Copy Markdown
Member

Thanks @rgommers we just hit this in mne-tools/mne-python#11760 (comment) !

@larsoner larsoner mentioned this pull request Jul 27, 2023
Merged
@pllim pllim mentioned this pull request Jul 27, 2023
Merged
@pllim

pllim commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Hello and thanks for this patch! Any chance scipy dev wheel can be updated with this included? Otherwise, I get import error if I test downstream with both numpy dev and scipy dev wheels.

@ev-br

ev-br commented Jul 27, 2023

Copy link
Copy Markdown
Member Author

so ideally it shouldn't have been there at all.

Yes, could have been just 1j, but then combined with things being arrays or 0D arrays or numpy scalars or python scalars... Safer just keep it as it was :-).

@rgommers

rgommers commented Jul 27, 2023

Copy link
Copy Markdown
Member

New wheels uploaded to https://anaconda.org/scientific-python-nightly-wheels/scipy/files minutes ago (some are still trickling in). Please let me know if that didn't do the trick.

@mattip mattip mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers approved these changes
@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner
@ilayn ilayn Awaiting requested review from ilayn ilayn is a code owner

Assignees

No one assigned

Labels

maintenance Items related to regular maintenance tasks scipy.linalg

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ev-br @rgommers @larsoner @pllim