Skip to content

CI: pin to rtools40#18374

Merged
andyfaff merged 4 commits intoscipy:mainfrom
andyfaff:pkgconfig
Apr 27, 2023
Merged

CI: pin to rtools40#18374
andyfaff merged 4 commits intoscipy:mainfrom
andyfaff:pkgconfig

Conversation

@andyfaff
Copy link
Copy Markdown
Contributor

There is a new rtools release on choco, version 4.3. This has caused a large proportion of Windows CI to stop working as the binaries are in a different place to the previous version available on choco. This meant that meson couldn't find pkg-config (different install location), so the whole build ground to a halt.

This PR pins the rtools version to 4.0. Decided to stick with that because 4.3 may bundle different gcc versions, etc.

@andyfaff
Copy link
Copy Markdown
Contributor Author

andyfaff commented Apr 26, 2023

I suspect that any upgrade step will solely involve changing instances of

echo "c:\rtools40\ucrt64\bin;" >> $env:GITHUB_PATH

to

echo "c:\rtools43\ucrt64\bin;" >> $env:GITHUB_PATH

@andyfaff andyfaff merged commit bf2af56 into scipy:main Apr 27, 2023
@andyfaff
Copy link
Copy Markdown
Contributor Author

Merging because changes straightforward and it keeps CI going.

@tylerjereddy tylerjereddy added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Apr 27, 2023
@tylerjereddy tylerjereddy added this to the 1.11.0 milestone Apr 27, 2023
@charris
Copy link
Copy Markdown
Member

charris commented Apr 27, 2023

Would this affect testing with fortran on windows?

@andyfaff
Copy link
Copy Markdown
Contributor Author

Not quite sure what the question is asking. The majority of the windows CI infra uses rtools to supply pkg-config, gcc, gfortran. The jobs started failing because the choco update meant rtools was in a different location, meaning that the build tools weren't found. This PR pins the version of rtools, so the tools that were working can be found again.
I am not sure if the new rtools package uses different versions of gcc/gfortran.

@charris
Copy link
Copy Markdown
Member

charris commented Apr 27, 2023

I was asking because we have started getting CI failures involving Fortran when running full tests on Windows 32 bit, see numpy/numpy#23675. I was wondering if there could be a connection.

@andyfaff
Copy link
Copy Markdown
Contributor Author

I think there will be a connection. The azure job installs rtools. Rtools43 is now the default on choco and that will be installed in a different location. I suspect you need to pin the version.

charris added a commit to charris/numpy that referenced this pull request Apr 28, 2023
@andyfaff andyfaff deleted the pkgconfig branch April 28, 2023 11:09
charris added a commit to charris/numpy that referenced this pull request May 3, 2023
charris added a commit to charris/numpy that referenced this pull request May 3, 2023
@charris
Copy link
Copy Markdown
Member

charris commented May 3, 2023

@andyfaff Just for your information, it turns out that rtools dropped support for 32 bit builds in version 4.2.

charris added a commit to charris/numpy that referenced this pull request May 3, 2023
charris added a commit to charris/numpy that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants