MAINT: Handle numpy's deprecation of accepting out-of-bound integers.#17209
Merged
rgommers merged 1 commit intoscipy:mainfrom Oct 12, 2022
Merged
MAINT: Handle numpy's deprecation of accepting out-of-bound integers.#17209rgommers merged 1 commit intoscipy:mainfrom
rgommers merged 1 commit intoscipy:mainfrom
Conversation
After the change in numpy/numpy#22385, numpy raises a deprecation warning with calls such as np.int8(5000) and np.uint32(-1). This change avoids such calls in the tests.
WarrenWeckesser
added
maintenance
rgommers
approved these changes
Oct 12, 2022
Member
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
All green, in it goes. Thanks @WarrenWeckesser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change in numpy/numpy#22385, numpy raises a deprecation warning with calls such as np.int8(5000) and np.uint32(-1). This change avoids such calls in the tests.