Repository navigation
MAINT: Fix Travis and Circle - #10540
Conversation
|
Also pushed a commit to bump tolerances in |
| A numpy.random.RandomState object for using the current state of the | ||
| created random generator container. | ||
| rand_state : `~numpy.random.mtrand.RandomState` object | ||
| A `~numpy.random.mtrand.RandomState` object for using the current state |
There was a problem hiding this comment.
Trims everything except what follows the last period in the ref (look at the rendered doc and you should see it)
|
LGTM since it makes the CI green again, modulo the explicit mtrand import. I'd wait for a numpy dev to confirm they are fine with this before merging this though. |
|
Yeah that doesn't look right. The objects are still there: So I think it's a change that just affected |
ah that's why it doesn't link.
Indeed, I do think these should not have been removed from the docs, they're not even deprecated. |
|
Well it's all still listed: https://numpy.org/devdocs/reference/random/legacy.html in the docs. It's too hard to find, and the main numpy.random docs reference For now though that won't unbreak our CI, that will take a 1.17.1 release I guess (that won't take very long, but more than a few days). So how about we merge this PR for now, fix the |
|
Sounds good to me. Though I'm not sure we even need an issue, CircleCI will yell at us when the intersphinx inventory reverts with 1.17.1, if they do decide to change back. |
|
OK, let's get this in, will open an issue in a moment. If CircleCI yells at us, great, we'll close it. EDIT: Opened gh-10545 |
|
Thanks Eric, Ralf, all. |
|
Ah, I do need the tolerance fix for |
* update SciPy 1.2.3 LTS release notes to account for a partial backport of scipygh-10540
signaltest so it should hopefully pass on OSXnumpy.randomnamespace changes.Closes #10535