Repository navigation
FIX: remove heavy-weight example files - #2
Conversation
|
This is fine if it's what we need to do. Yes, we'd need to change |
|
A couple other options (just to try to be complete and thoughtful):
I'm also good with simply removing per this PR and then when updating the commit hash for PROPACK in SciPy-proper, add required data for the test @mdhaber pointed out above |
|
+1 for just removing, and only keeping |
|
What size do you want the
|
That much still? I thought I had in a comment on the original PR that it'd be 2 MB. That would be acceptable (perhaps, just), I think 37 MB is way too much.
That sounds reasonable. I'm happy with either this approach or just using random matrices - whichever you prefer. |
|
I see at the top of this PR is that the PROPACK submodule would be 2MB after removing all the example files. |
@mdhaber was correct -- 2 MB without any examples or npz files Looks like this is a good solution -- remove the files from here and add a reduced npz file to main scipy repo. I'd feel weird about creating a PR and then completing it myself, so I invite either of you @rgommers @mdhaber to complete if you're happy |
|
I will, but I think we should merge scipy/scipy#15214 first so that there is no lapse in tests working |
|
Oh, sounds like we need to update a commit hash, so there's no lapse even if we merge this first? |
Correct, we need to explicitly commit a new hash in the parent SciPy repo for any changes here to take effect |
I have not evaluated the changes this will have to the
scipy.sparse.linalg.svdstest suite, I suspect there will need to be some adjustments. This PR is only to suggest one proposed approach for dealing with the PROPACK-size problem