Conversation
Member
SimonHeybrock
left a comment
SimonHeybrock
left a comment
There was a problem hiding this comment.
Looks ok, but should it also be added for non-time_point coords/edges?
Member
Author
|
Can do. I just wanted to be conservative to limit compile times and binary size. Should I add it? |
Member
|
I think this should be fine - compile+binary sizes are usually worst when we get some combination of variances/no-variances in multiple arguments, should not be an issue here? |
jl-wynen
changed the title
SimonHeybrock
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to apply time-dependent positions to detector events when loading from NeXus.
Draft for now until we decide if we even want to go this way.